Refactor date range picker#1225
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
sliding-interval-fix
branch
from
7a587f4 to
17736e6
Compare
david-crespo
changed the title
david-crespo
commented
Oct 14, 2022
|
|
||
| expect(onChange).toBeCalledWith(start, now) | ||
|
|
||
| vi.useRealTimers() |
Collaborator
Author
There was a problem hiding this comment.
Weirdly, when I had the vi.setSystemTime in a beforeAll or a beforeEach, it did not work. Something to remember, possibly a bug to report.
This was referenced Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it easier to slot in a date picker lib and it makes the whole thing work better.
<TextInput>and<Listbox>instead of Formik-ized<TextField>and<ListboxField>for the inputsaria-labeldirectly for SR users{ startTime, endTime, pickerElement }, we now have a normal component and a much smaller hook managingstartTimeandendTime, plus setting them from the initial value of the presetThe net line increase is not real; it's all in
yarn.lock. I upgraded vitest while trying to debug a timer issue in the tests and left it upgraded. Line count without that (git diff --stat main.. -- . ":(exclude)yarn.lock") is+387 -383Before
After